New patch for xfaces-3.3

Steve Kinzler (
Thu, 1 Aug 1996 15:51:44 -0500 (EST)

Subject: Minor xfaces patch
Date: Thu, 01 Aug 96 13:05:50 PDT
From: Ted Faber <faber@ISI.EDU>

Hi, guys. I'm not sure which of you I should send this to, but I found
a one line bug, a typo really, in the source to xfaces-3.3 available
from Steve's archive, and have a 1 line patch that fixes it.

In the code to construct the mailitem list from a command output, the
tail of the list isn't updated properly, which causes xfaces to dump core
when the list changes significantly. (Specifically, TheMailItemsTail is
NULL when TheMailItems isn't, which causes a NULL to be dereferenced.)
Here's the patch, do what you want with it.

I'm not on the faces mailing list, so my apologies if this has been
posted before.

*** mail_items.c.orig Thu Aug 1 12:47:42 1996
--- mail_items.c Thu Aug 1 00:46:43 1996
*** 651,656 ****
--- 651,657 ----
item->prev = TheMailItemsTail;
item->prev->next = item;
+ TheMailItemsTail = item;

item->face = FaceDisplay(item);